Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

[WIP] feat: async await #21

Closed
wants to merge 1 commit into from
Closed

[WIP] feat: async await #21

wants to merge 1 commit into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 30, 2018

More background about this effort: ipfs/js-ipfs#1670.

Depends on:

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@ghost ghost assigned hacdias Oct 30, 2018
@ghost ghost added the status/in-progress In progress label Oct 30, 2018
@hacdias hacdias requested review from vmx and alanshaw and removed request for vmx October 30, 2018 21:44
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     13    -5     
=====================================
- Hits           18     13    -5
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b21f6e...38f89ba. Read the comment docs.

@hacdias
Copy link
Member Author

hacdias commented Feb 25, 2019

@alanshaw @vmx what's the state of this?

@vmx
Copy link
Member

vmx commented Feb 25, 2019

@hacdias
Copy link
Member Author

hacdias commented Feb 26, 2019

@vmx gotcha! Then, perhaps, shouldn't we close this PRs on ipld side? Since there are major refactorings coming?

@vmx
Copy link
Member

vmx commented Feb 26, 2019

I first thought "yes, let's close it". But then after a second thought I might leave it open. I personally look at open issues/PRs more than on closed one. There's certainly a discoverability issue here, that the refactoring is coming. So my hope would be that anyone trying to hop in to help with the async/await endeavour, to find those already open PRs and won't work on it.

What do you think @hacdias?

@hacdias
Copy link
Member Author

hacdias commented Feb 26, 2019

@vmx I agree with the (in)visibility of the issues/PRs when they're closed/open. Although I also find it distracting and we always have ipfs/js-ipfs#1670 to keep track of all of the async await changes.

@vmx
Copy link
Member

vmx commented May 8, 2019

Superseded by #32.

@vmx vmx closed this May 8, 2019
@ghost ghost removed the status/in-progress In progress label May 8, 2019
@hacdias hacdias deleted the feat/async-await branch May 8, 2019 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants